[PATCH] D18963: PR27216: Only define __ARM_FEATURE_FMA when the target has VFPv4

silviu.baranga@arm.com via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 26 06:39:19 PDT 2016


sbaranga added inline comments.

================
Comment at: lib/Basic/Targets.cpp:4710
@@ -4709,1 +4709,3 @@
                  const std::vector<std::string> &FeaturesVec) const override {
+    if (CPU == "")
+      CPU = "generic";
----------------
rengolin wrote:
> This change is unrelated and may bring side effects into clang. I'd keep this out and investigate it in another patch with the appropriate tests. If you just force the target-feature in the test, this corner case won't be relevant in this patch.
Ok, that makes sense. I'll revert to the previous revision of this patch.


http://reviews.llvm.org/D18963





More information about the cfe-commits mailing list