[PATCH] D19497: [clang-tidy] Enhance misc-suspicious-string-compare to move down false-positives.

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 26 06:12:47 PDT 2016


alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.

LG with one nit.


================
Comment at: clang-tidy/misc/SuspiciousStringCompareCheck.cpp:215
@@ +214,3 @@
+  if (Result.Nodes.getNodeAs<Stmt>("suspicious-operator")) {
+    diag(Call->getLocStart(), "suspicious usage of function %0") << Decl;
+  }
----------------
Can you make the message more specific? It should make it clear, what exactly is "suspicious" in this usage.


http://reviews.llvm.org/D19497





More information about the cfe-commits mailing list