[PATCH] D19382: [OpenMP] Improve mappable expressions Sema.

Alexey Bataev via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 25 22:26:29 PDT 2016


ABataev accepted this revision.
This revision is now accepted and ready to land.

================
Comment at: lib/AST/OpenMPClause.cpp:546
@@ +545,3 @@
+  for (auto *D : Declarations) {
+    assert(
+        (!D || D->isCanonicalDecl()) &&
----------------
sfantao wrote:
> Ok, using canonical declarations now. 
> 
No, I mean you'd better to check and store canonical decls in Cache, like:
```
if (Cache.count(D->getCaonicalDecl())
```
```
Cache.insert(D->getCanonicalDecl());
```



http://reviews.llvm.org/D19382





More information about the cfe-commits mailing list