[PATCH] D19425: driver: Add a `--rsp-quoting` flag to choose which unquoting behavior to use in rsp files.

[Reid Kleckner via cfe-commits]

rnk added inline comments.

================
Comment at: tools/driver/driver.cpp:350
@@ +349,3 @@
+  for (const char *F : argv) {
+    if (strcmp(F, "--rsp-quoting=posix") == 0)
+      RSPQuoting = POSIX;
----------------
thakis wrote:
> rnk wrote:
> > Should we call it "posix" or "gnu"? The reference implementation we are trying to match is part of libiberty, which is why I called the tokenizer TokenizeGNUCommandLine.
> I figured the reference implementation tries to implement http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html from posix, but I don't care much about the name. If you prefer gnu, I'm happy to use gnu. (In the same vein: Do you have an opinion on "windows" vs "cl" vs "msvc"?)
I buy that reasoning, let's use "posix" then.

I also like "windows" for the other style. The algorithm documented at https://msdn.microsoft.com/en-us/library/17w5ykft(v=vs.85).aspx is pretty standard. New versions of mingw use the exact same algorithm.


http://reviews.llvm.org/D19425