[PATCH] D19194: fix for clang-tidy modernize-pass-by-value on copy constructor

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 25 10:49:44 PDT 2016


alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.

This test doesn't fail without your fix.


================
Comment at: clang-tidy/modernize/PassByValueCheck.cpp:155
@@ -155,1 +154,3 @@
+                    .bind("Initializer")),
+             unless(isCopyConstructor()))
             .bind("Ctor"),
----------------
This submatcher is much cheaper, so it should go first to make the whole matcher more efficient.


http://reviews.llvm.org/D19194





More information about the cfe-commits mailing list