[PATCH] D18768: Refactoring attribute subject diagnostics

Richard Smith via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 22 16:54:33 PDT 2016


rsmith added a comment.

I think this is a reasonable direction. I'd like to see some kind of %list form added to our diagnostics system, but I don't mind whether that happens before or after this change.

(I'd also prefer to use singular forms in the various subject names, but that seems to create problems with the presence/absence of "a" / "an". If you see a way to make that work, we should consider it, but otherwise don't worry about it.)


http://reviews.llvm.org/D18768





More information about the cfe-commits mailing list