[PATCH] D18657: Propagate missing empty exception spec from function declared in system header

John McCall via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 22 13:18:18 PDT 2016

rjmccall added inline comments.

Comment at: lib/Sema/SemaExceptionSpec.cpp:260
@@ -261,1 +259,3 @@
+      (First->getLocation().isInvalid() ||
+       Context.getSourceManager().isInSystemHeader(First->getLocation()))) {
rsmith wrote:
> rjmccall wrote:
> > Please find a way to sink the call to getFirstDecl() to the point where we need it.
> `getFirstDecl` is cheap these days.
Ah, nevermind then.


More information about the cfe-commits mailing list