[PATCH] D19425: driver: Add a `--rsp-quoting` flag to choose which unquoting behavior to use in rsp files.

Nico Weber via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 22 11:50:49 PDT 2016

thakis created this revision.
thakis added a reviewer: rnk.
thakis added a subscriber: cfe-commits.

Currently, clang-cl always uses Windows style for unquoting, and clang always uses POSIX style for unquoting.

In general, response file quoting should match the shell the response file is used in. On Windows, it's possible to run clang-cl in a bash shell, or clang in cmd.exe, so a flag for overriding the default behavior is natural there. On non-Windows, Windows probably never makes sense (except maybe in Wine), but having clang-cl behave differently based on the host OS seems strange too -- people who want to use clang-cl on non-Windows with "native" response files will have to pass --rsp-quoting=posix.

This also includes the clang-side test changes needed for http://reviews.llvm.org/D19417



-------------- next part --------------
A non-text attachment was scrubbed...
Name: D19425.54691.patch
Type: text/x-patch
Size: 4428 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160422/774ed434/attachment.bin>

More information about the cfe-commits mailing list