[PATCH] D19071: [OpenCL] Add predefined macros.

Anastasia Stulova via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 21 10:45:03 PDT 2016


Anastasia added inline comments.

================
Comment at: lib/Frontend/InitPreprocessor.cpp:418
@@ +417,3 @@
+    // A shared OpenCL header file requires a macro to indicate the language
+    // standard. As a workaround, __CLANG_OPENCL_C_VERSION__ is defined for
+    // OpenCL v1.0 and v1.1.
----------------
CLANG_OPENCL_C_VERSION -> OPENCL_C_VERSION

================
Comment at: test/Frontend/stdlang.c:11
@@ -3,2 +10,3 @@
+// CHECK-INVALID: error: invalid value 'invalid' in '-cl-std=invalid'
 // expected-no-diagnostics
 
----------------
I still think that "// expected-no-diagnostics" is not needed here as we don't pass -verify.


http://reviews.llvm.org/D19071





More information about the cfe-commits mailing list