[PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

Samuel Benzaquen via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 21 10:31:18 PDT 2016

sbenza added inline comments.

Comment at: lib/AST/ASTContext.cpp:1279
@@ -1282,1 +1278,3 @@
+const ASTContext::CXXMethodVector *
+ASTContext::overridden_methods(const CXXMethodDecl *Method) const {
   llvm::DenseMap<const CXXMethodDecl *, CXXMethodVector>::const_iterator Pos
It would be simpler to return `ArrayRef<const CXXMethodDecl*>`.
That way the caller doesn't need to deal with a potential null pointer or with the custom vector type.


More information about the cfe-commits mailing list