[PATCH] D19194: fix for clang-tidy modernize-pass-by-value on copy constructor

Kamal Essoufi via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 21 10:09:19 PDT 2016


Kessoufi updated this revision to Diff 54524.
Kessoufi added a comment.

removed the redundant matcher


http://reviews.llvm.org/D19194

Files:
  clang-tidy/modernize/PassByValueCheck.cpp

Index: clang-tidy/modernize/PassByValueCheck.cpp
===================================================================
--- clang-tidy/modernize/PassByValueCheck.cpp
+++ clang-tidy/modernize/PassByValueCheck.cpp
@@ -148,7 +148,7 @@
                                           nonConstValueType()))))
                                 .bind("Param")))),
                         hasDeclaration(cxxConstructorDecl(
-                            isCopyConstructor(), unless(isDeleted()),
+                            unless(isCopyConstructor()),
                             hasDeclContext(
                                 cxxRecordDecl(isMoveConstructible())))))))
                     .bind("Initializer")))


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D19194.54524.patch
Type: text/x-patch
Size: 702 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160421/2969d2fe/attachment.bin>


More information about the cfe-commits mailing list