[PATCH] D19249: Fix include path in ClangTidy.cpp.

[Stephen Hines via cfe-commits]

srhines added inline comments.

================
Comment at: clang-tidy/ClangTidy.cpp:61
@@ -60,3 +60,3 @@
   FULLNAME,
-#include "../../../lib/StaticAnalyzer/Checkers/Checkers.inc"
+#include "Checkers.inc"
 #undef CHECKER
----------------
alexfh wrote:
> As it is, the change leaves almost no context of where the Checkers.inc file comes from. I'd prefer to leave at least `lib/StaticAnalyzer/Checkers/Checkers.inc`. Will this work for you?
> 
> Another question is how do you deal with other .inc files generated from .td files in llvm/lib/... or llvm/tools/clang/lib/...?
I think that the other .inc files have proper exported include paths so that you only include the final part of the name.

Looking at llvm/lib/Option/CMakeLists.txt, I see the following export o fthe includes:

  ADDITIONAL_HEADER_DIRS
  ${LLVM_MAIN_INCLUDE_DIR}/llvm/Option
  )

Should this export actually be happening in lib/StaticAnalyzer/Checkers/CMakeLists.txt? Even in that case, it will shorten down to just the final name, without any other part of the path (like you are requesting here).


http://reviews.llvm.org/D19249