[PATCH] D19324: [ASTMatchers] new forEachOverriden matcher
Aaron Ballman via cfe-commits
cfe-commits at lists.llvm.org
Thu Apr 21 06:14:52 PDT 2016
aaron.ballman added inline comments.
================
Comment at: include/clang/ASTMatchers/ASTMatchers.h:3724
@@ +3723,3 @@
+ bool Matched = false;
+ for (auto It = Node.begin_overridden_methods();
+ It != Node.end_overridden_methods(); ++It) {
----------------
courbet wrote:
> aaron.ballman wrote:
> > Can you range-ify this for loop?
> I could do that , but it would require adding:
>
> ```const CXXMethodVector* ASTContext::overridden_methods() const;```
>
> And plumbing it through. (or did I miss something ?)
>
> Let me know what you think.
I think it's an oversight that we don't have the range form of that function, and this seems like a reasonable use case to add it.
http://reviews.llvm.org/D19324
More information about the cfe-commits
mailing list