[PATCH] D19324: [ASTMatchers] new forEachOverriden matcher
Aaron Ballman via cfe-commits
cfe-commits at lists.llvm.org
Thu Apr 21 05:48:22 PDT 2016
aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added a comment.
Please run clang\docs\tools\dump_ast_matchers.py to regenerate the documentation as well.
================
Comment at: include/clang/ASTMatchers/ASTMatchers.h:3724
@@ +3723,3 @@
+ bool Matched = false;
+ for (auto It = Node.begin_overridden_methods();
+ It != Node.end_overridden_methods(); ++It) {
----------------
Can you range-ify this for loop?
================
Comment at: unittests/ASTMatchers/ASTMatchersTest.cpp:2084
@@ +2083,3 @@
+ Code1, ForEachOverriddenInClass("C"),
+ new VerifyIdIsBoundTo<CXXMethodDecl>("override", "f", 1)));
+ EXPECT_TRUE(matchAndVerifyResultTrue(
----------------
Can you write the tests such that they don't leak?
http://reviews.llvm.org/D19324
More information about the cfe-commits
mailing list