[PATCH] D18624: [PGO] PGOFuncName meta data if PGOFuncName is different from function's raw name.

[Rong Xu via cfe-commits]

the reason for splitting the check is we don't need this check at all in
llvm instrument,-- as it's done per function. but I guess it does not
matter much to move it in to create -- it's only called once per function.





On Wed, Apr 20, 2016 at 3:04 PM, David Li <davidxl at google.com> wrote:

> davidxl added inline comments.
>
> ================
> Comment at: lib/CodeGen/CodeGenPGO.cpp:47
> @@ +46,3 @@
> +  // Create PGOFuncName meta data.
> +  if (!llvm::getPGOFuncNameMetadata(*Fn))
> +    llvm::createPGOFuncNameMetadata(*Fn);
> ----------------
> This check be folded into the creator. The creator interface name also
> needs to be changed properly (created when needed)
>
>
> http://reviews.llvm.org/D18624
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160420/808e39b3/attachment.html>