[PATCH] D18953: [ms][dll] #26935 Defining a dllimport function should cause it to be exported

Richard Smith via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 20 15:18:14 PDT 2016

rsmith added a comment.

In http://reviews.llvm.org/D18953#397279, @rnk wrote:

> Richard, do you think we should be handling this by rewriting the AST-level attribute in Sema or by changing our interpretation of things in CodeGen? We're already creating a bunch of implicit attributes to implement class-level import/export.

Sorry, I forgot to answer this directly. I'm fine with either approach; they both seem to preserve source fidelity and allow AST clients to figure out what's going on without too much complexity.


More information about the cfe-commits mailing list