[PATCH] D19299: lower __builtin_expect() directly to prof metadata instead of LLVM intrinsic

Amaury SECHET via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 20 11:27:56 PDT 2016

deadalnix added a comment.

In http://reviews.llvm.org/D19299#406517, @spatel wrote:

> Rereading your question, I'm now wondering if you are asking if we can get rid of the source level builtin_unpredictable() ? I had not considered that, but I think that is also possible if we add a flag to builtin_expect() to mean 'this branch is unpredictable'.
> Please let me know if I answered the correct question. :)

You did answer my question. I don't really mind source level intrinsic, I'm more concerned about the IR and how they are lowered. Overall I like where this is going. It looks like @davidxl is on it for the review, and he seems to have a good idea of where this should go, so I'll defer to him for acceptance/change requests.


More information about the cfe-commits mailing list