[PATCH] D19071: [OpenCL] Add predefined macros.

[Anastasia Stulova via cfe-commits]

Anastasia added inline comments.

================
Comment at: lib/Frontend/InitPreprocessor.cpp:421
@@ +420,3 @@
+    switch (LangOpts.OpenCLVersion) {
+    case 100:
+      Builder.defineMacro("__OPENCL_C_VERSION__", "100");
----------------
Yes, perfectly makes sense. I don't think passing C std flag should be allowed since OpenCL is based strictly on C99 and use of other versions are not possible anyways.

Nice cleanup!

================
Comment at: lib/Frontend/InitPreprocessor.cpp:439
@@ +438,3 @@
+    Builder.defineMacro("CL_VERSION_1_2", "120");
+    Builder.defineMacro("CL_VERSION_2_0", "200");
+
----------------
Could you update the test please. 

================
Comment at: test/Frontend/stdlang.c:10
@@ -3,1 +9,3 @@
+#ifndef OPENCL_C99
 // expected-no-diagnostics
+#endif
----------------
I think expected-no-diagnostics is only used if -verify is passed.


http://reviews.llvm.org/D19071