[PATCH] D19274: Compilation for Intel MCU (Part 2/3)

[Andrey Turetskiy via cfe-commits]

aturetsk added a comment.

Hi Mandeep,
Thanks for the review.


================
Comment at: lib/Driver/ToolChains.cpp:2153
@@ -2148,1 +2152,3 @@
+  FilterNonExistent NonExistent(
+      Path, TargetTriple.isOSIAMCU() ? "/libgcc.a" : "/crtbegin.o", D.getVFS());
 
----------------
Does anybody know if 'libgcc.a' could be used instead of 'crtbegin.o' for all targets?
If so we can avoid changing FilterNonExistent so much...

================
Comment at: lib/Driver/Tools.cpp:583
@@ -575,3 +582,3 @@
 // FIXME: Move to target hook.
 static bool isSignedCharDefault(const llvm::Triple &Triple) {
   switch (Triple.getArch()) {
----------------
Done.

================
Comment at: lib/Driver/Tools.cpp:3624
@@ +3623,3 @@
+  // C++ is not supported for IAMCU.
+  if (IsIAMCU && types::isCXX(Input.getType()))
+    D.Diag(diag::err_drv_cxx_not_supported) << getToolChain().getTriple().str();
----------------
Fixed.


http://reviews.llvm.org/D19274