[PATCH] D19278: [scan-build] fix logic error warnings emitted on clang code base
John McCall via cfe-commits
cfe-commits at lists.llvm.org
Tue Apr 19 13:57:01 PDT 2016
rjmccall added inline comments.
================
Comment at: lib/Sema/SemaOverload.cpp:9191
@@ -9189,1 +9190,3 @@
+ ToTy->isLValueReferenceType() &&
+ !FromExpr->isLValue() &&
ToTy.getNonReferenceType().getCanonicalType() ==
----------------
Interleaving these conditions looks strange. Please group the FromExpr-related checks next to each other.
Otherwise LGTM.
http://reviews.llvm.org/D19278
More information about the cfe-commits
mailing list