[PATCH] D19274: Compilation for Intel MCU (Part 2/3)

Mandeep Singh Grang via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 19 11:10:14 PDT 2016


mgrang added a subscriber: mgrang.

================
Comment at: lib/Driver/Tools.cpp:580
@@ -573,1 +579,3 @@
+  if (IsIAMCU)
+    getToolChain().AddIAMCUIncludeArgs(Args, CmdArgs);
 }
----------------
Is it better to move this above in the else part of the condition "if (!IsIAMCU)"?

================
Comment at: lib/Driver/Tools.cpp:3625
@@ +3624,3 @@
+  // C++ is not supported for IAMCU.
+  if(IsIAMCU && types::isCXX(Input.getType()))
+    D.Diag(diag::err_drv_cxx_not_supported) << getToolChain().getTriple().str();
----------------
nitpick: Missing space between if and (


http://reviews.llvm.org/D19274





More information about the cfe-commits mailing list