[PATCH] D16544: [libcxx] Framework to allow testing of static libc++abi

[Ben Craig via cfe-commits]

bcraig closed this revision.
bcraig added a comment.

r266730


================
Comment at: test/libcxx/test/config.py:454
@@ -464,1 +453,3 @@
+            else:
+                self.cxx.link_flags += ['-lc++']
 
----------------
EricWF wrote:
> In this fallback case do we want to explicitly ask for static linkage using `-Wl,-Bstatic -lc++ -Wl,-Bdynamic`? I think that will cause the linker to diagnose that your not actually getting a static library.
While I would like to get a the diagnosis, I don't plan on making this change.  The hexagon linker (and maybe others?) default to -Bstatic, so the "restoration" half of that snippet does the wrong thing.  If there were a way to save / push the linker state, then restore / pop it then I would do that.


http://reviews.llvm.org/D16544