[PATCH] D16544: [libcxx] Framework to allow testing of static libc++abi
Eric Fiselier via cfe-commits
cfe-commits at lists.llvm.org
Mon Apr 18 13:03:55 PDT 2016
EricWF added a comment.
In http://reviews.llvm.org/D16544#404283, @bcraig wrote:
> In http://reviews.llvm.org/D16544#403273, @EricWF wrote:
>
> > Just spitballing but have you considered simply passing the full path, including the library name, to LIT? Instead of needing `enable_shared` variables we would simply use the named library, be it DSO or archive.
>
>
> I agree that this would be nice. I don't really like the nest of if / else statements that I currently have in place. However, I have now attempted to do this, and failed. My cmake-fu just isn't strong enough.
OK. Thanks for looking into this. I figured CMake would stand in our way. Last I looked into it CMake doesn't actually know the name of the library it's going to produce until way to late in the configuration process.
Lets go ahead with this.
http://reviews.llvm.org/D16544
More information about the cfe-commits
mailing list