[PATCH] D18136: boost-use-to-string check
Alexander Kornienko via cfe-commits
cfe-commits at lists.llvm.org
Mon Apr 18 06:51:33 PDT 2016
alexfh added inline comments.
================
Comment at: clang-tidy/boost/UseToStringCheck.cpp:53
@@ +52,3 @@
+ CharType->isSpecificBuiltinType(BuiltinType::Char_U))
+ // Is CharType 'char'.
+ StringType = "string";
----------------
These comments don't seem to be useful, but if you want to leave them, please surround the bodies with braces, since they are longer than one line.
================
Comment at: clang-tidy/boost/UseToStringCheck.cpp:60
@@ +59,3 @@
+ else
+ return;
+
----------------
Please add a reduced test case for this.
http://reviews.llvm.org/D18136
More information about the cfe-commits
mailing list