[PATCH] D17410: [libcxxabi] Respect LIBCXXABI_LIBDIR_SUFFIX before an install
Eric Fiselier via cfe-commits
cfe-commits at lists.llvm.org
Fri Apr 15 18:53:27 PDT 2016
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
So we already do this for the standalone builds but not for in-tree builds.
Before committing please make sure to remove the code on CMakeLists.txt line 99 that does this same thing.
I'm assuming changing these CMake variables doesn't propagate upwards to other in-tree projects?
My one concern is that libc++ won't be able to find libc++abi when it's in a custom directory.
But that shouldn't cause problems unless it's made to.
After all that this LGTM.
http://reviews.llvm.org/D17410
More information about the cfe-commits
mailing list