[PATCH] D18637: Extract key to avoid preemptive mallocs in insert/emplace in associative containers

Eric Fiselier via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 15 16:30:06 PDT 2016


EricWF updated this revision to Diff 53968.
EricWF added a comment.

I've silenced the tests when they pass as suggested. I added a 'assert_checkpoint.h' support header that stores the last checkpoint a test has passed and prints that information when std::abort is called.

I also moved the allocator requirement test templates into generic headers so the same version can be used by both the associative and unordered containers.  Previously each test was duplicated.


http://reviews.llvm.org/D18637

Files:
  include/__hash_table
  include/__tree
  include/__tuple
  include/type_traits
  test/std/containers/associative/map/map.modifiers/insert_allocator_requirements.pass.cpp
  test/std/containers/associative/map/map.modifiers/insert_and_emplace_allocator_requirements.pass.cpp
  test/std/containers/associative/multimap/multimap.modifiers/insert_allocator_requirements.pass.cpp
  test/std/containers/associative/multiset/insert_allocator_requirements.pass.cpp
  test/std/containers/associative/set/insert_allocator_requirements.pass.cpp
  test/std/containers/associative/set/insert_and_emplace_allocator_requirements.pass.cpp
  test/std/containers/map_allocator_requirement_test_templates.h
  test/std/containers/set_allocator_requirement_test_templates.h
  test/std/containers/unord/unord.map/unord.map.modifiers/insert_and_emplace_allocator_requirements.pass.cpp
  test/std/containers/unord/unord.multimap/unord.multimap.modifiers/insert_allocator_requirements.pass.cpp
  test/std/containers/unord/unord.multiset/insert_allocator_requirements.pass.cpp
  test/std/containers/unord/unord.set/insert_and_emplace_allocator_requirements.pass.cpp
  test/support/assert_checkpoint.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D18637.53968.patch
Type: text/x-patch
Size: 65940 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160415/b3b6a904/attachment-0001.bin>


More information about the cfe-commits mailing list