[PATCH] D19144: Handle TemplateArgument in DynTypedNode comparison operations.

[Samuel Benzaquen via cfe-commits]

sbenza added a comment.

I think the bug is coming from `memoizedMatchesAncestorOfRecursively`.
`memoizedMatchesRecursively` has a special case at the top to skip the cache if the node is not sortable. The other function should do that too.
Although the check is stale also because it is only checking for memoizationData and not whether the node itself works for < and ==.

Note that adding TemplateArgument to the function is ok, but that won't fix the bug because we still have other nodes that are not comparable.


================
Comment at: include/clang/AST/ASTTypeTraits.h:269
@@ -268,3 +268,3 @@
   ///
   /// Supports comparison of nodes that support memoization.
   /// FIXME: Implement comparsion for other node types (currently
----------------
this comment is stale.


http://reviews.llvm.org/D19144