[PATCH] D18369: [OpenCL] Upstreaming khronos OpenCL header file.

Alexey Bader via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 15 05:44:10 PDT 2016


bader added inline comments.

================
Comment at: lib/Headers/opencl.h:15372-15373
@@ +15371,4 @@
+ */
+int __const_func __attribute__((overloadable)) get_image_width(image1d_t image);
+int __const_func __attribute__((overloadable)) get_image_width(image1d_buffer_t image);
+int __const_func __attribute__((overloadable)) get_image_width(image2d_t image);
----------------
Please, add image access qualifier to Built-in Image Query Functions declarations. It's required by OpenCL 2.0 specification.
OpenCL 1.x spec. defines built-in functions w/o access qualifiers (i.e. 'read_only' is applied).


http://reviews.llvm.org/D18369





More information about the cfe-commits mailing list