[PATCH] D19117: [clang-tidy] Update RedundantVoidArgCheck to check for type aliases in addition to typedefs
Clement Courbet via cfe-commits
cfe-commits at lists.llvm.org
Thu Apr 14 10:54:53 PDT 2016
courbet added a comment.
Thanks for the review !
> I can submit the patch on your behalf if you would like.
That'd be great, thank you.
================
Comment at: clang-tidy/modernize/RedundantVoidArgCheck.cpp:109-111
@@ -107,5 +108,5 @@
SourceLocation Start = Function->getLocStart();
- SourceLocation End = Body ? Body->getLocStart().getLocWithOffset(-1) :
- Function->getLocEnd();
+ SourceLocation End =
+ Body ? Body->getLocStart().getLocWithOffset(-1) : Function->getLocEnd();
removeVoidArgumentTokens(Result, SourceRange(Start, End),
"function definition");
----------------
aaron.ballman wrote:
> Generally, you run clang-format just over the patch so that you're only formatting the code you've touched. However, if you ran clang-format over the entire file and this is the only change it produced, I think it's fine as a drive-by. If it produced more changes, then I would say submit all of the formatting changes as a secondary patch.
Thanks, that's what I though. The test file had a ton of reformatting changes, so I left it out.
http://reviews.llvm.org/D19117
More information about the cfe-commits
mailing list