[PATCH] D19105: Changes in clang after running http://reviews.llvm.org/D18821

Piotr Padlewski via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 14 04:10:25 PDT 2016


Prazek created this revision.
Prazek added a reviewer: alexfh.
Prazek added a subscriber: cfe-commits.
Herald added a subscriber: klimek.

I am not done with analysis, and I don't want to push it to repo as it is, because in many cases when programmer wrote true/false he wanted to have bool instead of int.

Some nice example:
 unsigned IsFilled : 1;

  /// Simplified kind of \c CommentDecl, see \c DeclKind enum.
  unsigned Kind : 3;

  /// Is \c CommentDecl a template declaration.
  unsigned TemplateKind : 2;

  /// Is \c CommentDecl an ObjCMethodDecl.
  unsigned IsObjCMethod : 1;

  /// Is \c CommentDecl a non-static member function of C++ class or
  /// instance method of ObjC class.
  /// Can be true only if \c IsFunctionDecl is true.
  unsigned IsInstanceMethod : 1;

  /// Is \c CommentDecl a static member function of C++ class or
  /// class method of ObjC class.
  /// Can be true only if \c IsFunctionDecl is true.
  unsigned IsClassMethod : 1;

I want to replace all unsigned that are 1 bits with bool.

http://reviews.llvm.org/D19105

Files:
  lib/ARCMigrate/ARCMT.cpp
  lib/ARCMigrate/ObjCMT.cpp
  lib/AST/ASTContext.cpp
  lib/AST/ASTDiagnostic.cpp
  lib/AST/Comment.cpp
  lib/AST/CommentCommandTraits.cpp
  lib/AST/CommentSema.cpp
  lib/AST/Decl.cpp
  lib/AST/DeclBase.cpp
  lib/AST/DeclCXX.cpp
  lib/AST/DeclObjC.cpp
  lib/AST/DeclPrinter.cpp
  lib/AST/DeclTemplate.cpp
  lib/AST/DeclarationName.cpp
  lib/AST/Expr.cpp
  lib/AST/ExprCXX.cpp
  lib/AST/ExprObjC.cpp
  lib/AST/RecordLayoutBuilder.cpp
  lib/AST/TemplateBase.cpp
  lib/AST/TemplateName.cpp
  lib/AST/Type.cpp
  lib/AST/TypePrinter.cpp
  lib/Analysis/CFG.cpp
  lib/Basic/Diagnostic.cpp
  lib/Basic/Module.cpp
  lib/Basic/SourceManager.cpp
  lib/Basic/TargetInfo.cpp
  lib/Basic/Targets.cpp
  lib/CodeGen/CGAtomic.cpp
  lib/CodeGen/CGBuiltin.cpp
  lib/CodeGen/CGObjC.cpp
  lib/CodeGen/CGOpenMPRuntime.cpp
  lib/CodeGen/ObjectFilePCHContainerOperations.cpp
  lib/Driver/Driver.cpp
  lib/Driver/Tools.cpp
  lib/Frontend/ASTUnit.cpp
  lib/Frontend/CompilerInstance.cpp
  lib/Frontend/CompilerInvocation.cpp
  lib/Frontend/FrontendActions.cpp
  lib/Index/CommentToXML.cpp
  lib/Index/IndexSymbol.cpp
  lib/Index/USRGeneration.cpp
  lib/Lex/HeaderSearch.cpp
  lib/Lex/Lexer.cpp
  lib/Lex/ModuleMap.cpp
  lib/Lex/PPMacroExpansion.cpp
  lib/Sema/DeclSpec.cpp
  lib/Sema/Sema.cpp
  lib/Sema/SemaChecking.cpp
  lib/Sema/SemaCodeComplete.cpp
  lib/Sema/SemaDecl.cpp
  lib/Sema/SemaDeclAttr.cpp
  lib/Sema/SemaDeclCXX.cpp
  lib/Sema/SemaDeclObjC.cpp
  lib/Sema/SemaOpenMP.cpp
  lib/Sema/SemaOverload.cpp
  lib/Sema/SemaStmt.cpp
  lib/Sema/SemaType.cpp
  lib/Serialization/ASTReader.cpp
  lib/Serialization/ASTReaderDecl.cpp
  lib/Serialization/ASTWriter.cpp
  lib/StaticAnalyzer/Checkers/DebugCheckers.cpp
  lib/StaticAnalyzer/Frontend/ModelInjector.cpp
  lib/Tooling/Core/QualTypeNames.cpp
  lib/Tooling/Tooling.cpp
  tools/libclang/CIndex.cpp
  tools/libclang/CXComment.cpp
  tools/libclang/CXCursor.cpp
  tools/libclang/CXIndexDataConsumer.cpp
  tools/libclang/CXType.cpp
  tools/libclang/Indexing.cpp
  unittests/AST/DeclPrinterTest.cpp
  unittests/Frontend/FrontendActionTest.cpp
  unittests/Tooling/ToolingTest.cpp
  unittests/libclang/LibclangTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D19105.53687.patch
Type: text/x-patch
Size: 132026 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160414/b88f469f/attachment-0001.bin>


More information about the cfe-commits mailing list