[PATCH] D19059: Reorder ASTNodeKind::AllKindInfo to match NodeKindId.

Samuel Benzaquen via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 13 08:27:59 PDT 2016


sbenza added a comment.

Those tests are testing the code completion you get in clang-query.
The type list must match what that matcher supports.

`hasParent` is declared as

  const internal::ArgumentAdaptingMatcherFunc<
      internal::HasParentMatcher,
      internal::TypeList<Decl, NestedNameSpecifierLoc, Stmt, TypeLoc>,
      internal::TypeList<Decl, NestedNameSpecifierLoc, Stmt, TypeLoc>>
      LLVM_ATTRIBUTE_UNUSED hasParent = {};

so the completion message is correct now.


================
Comment at: unittests/AST/ASTTypeTraitsTest.cpp:118
@@ +117,3 @@
+  VERIFY_NAME(NestedNameSpecifier);
+  VERIFY_NAME(Decl);
+  VERIFY_NAME(Stmt);
----------------
Add a derived Decl type too.
You added one for Stmt and Type, but not for Decl.


http://reviews.llvm.org/D19059





More information about the cfe-commits mailing list