[PATCH] D18652: [Inline asm] Correctly parse GCC-style asm line following MS-style asm line

[Denis Zobnin via cfe-commits]

d.zobnin.bugzilla added a reviewer: rsmith.
d.zobnin.bugzilla removed a subscriber: rsmith.
d.zobnin.bugzilla updated this revision to Diff 53543.
d.zobnin.bugzilla added a comment.

Richard, thank you for the review!

I've created a static function to check if this is a GCC asm statement as you recommended to do, and also made "isTypeQualifier" function static.
I've added a check for "goto" after "asm" to treat such statements as GCC-style assembly.
Also, do you think it will be better to diagnose unsupported "asm goto" statements rather than fall into parsing them and emit "expected identifier" error or something like that?

Thank you,
Denis Zobnin


http://reviews.llvm.org/D18652

Files:
  include/clang/Basic/DiagnosticParseKinds.td
  include/clang/Parse/Parser.h
  lib/Parse/ParseDecl.cpp
  lib/Parse/ParseStmtAsm.cpp
  test/CodeGen/inline-asm-mixed-style.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D18652.53543.patch
Type: text/x-patch
Size: 5811 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160413/64a32552/attachment-0001.bin>