[PATCH] D18914: [clang-tidy] new readability-redundant-inline

Samuel Benzaquen via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 12 08:10:42 PDT 2016


sbenza added inline comments.

================
Comment at: clang-tidy/readability/RedundantInlineCheck.cpp:68
@@ +67,3 @@
+  }
+  llvm_unreachable("InlineTok() did not encounter the 'inline' token");
+}
----------------
This is still reachable.
The token might be hidden through macros, for example.
But even then we still can keep a simple API. The possible return values are a token or 'not found'.
Optional<Token> should be ok.


http://reviews.llvm.org/D18914





More information about the cfe-commits mailing list