[PATCH] D18657: Propagate missing empty exception spec from function declared in system header
John McCall via cfe-commits
cfe-commits at lists.llvm.org
Mon Apr 11 20:42:18 PDT 2016
rjmccall added a comment.
IIRC, isInSystemHeader isn't a terribly cheap check. Please extract this into a function that only needs to be called if the other checks succeed.
You should also be able to just ask about the first declaration. There are contrived situations where isInSystemHeader can be false for the first declaration and true for later ones, but we don't need to fall over ourselves supporting them.
http://reviews.llvm.org/D18657
More information about the cfe-commits
mailing list