[PATCH] D18849: [modules] Avoid module relocation error when building modules from VFS

Ben Langmuir via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 11 13:11:23 PDT 2016


benlangmuir added a comment.

This doesn't appear to be a safe change.  We can't assume that `RootName` wouldn't ever be legitimately found somewhere in a path (even without a VFS) and changing the path prefix could give a completely different location.  I would also be concerned about the performance impact of performing two lookups, since finding a module for a header is not always a cheap operation.

I'm not sure off hand how else to fix this.


http://reviews.llvm.org/D18849





More information about the cfe-commits mailing list