[PATCH] D18961: Add a readability-deleted-default clang-tidy check.

Alex Pilkiewicz via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 11 11:25:27 PDT 2016


pilki added a comment.

I hope I answered all comments (sorry if I missed some, I'm not yet used to this UI).

I have an open question about isInTemplateInstantiation, and added a test (since I missed templated function)


================
Comment at:  clang-tidy/readability/DeletedDefaultCheck.cpp:27
@@ +26,3 @@
+  const auto NotTemplate = unless(hasAncestor(
+      cxxRecordDecl(::clang::ast_matchers::isTemplateInstantiation())));
+
----------------
alexfh wrote:
> What about this comment?
isInTemplateInstantiation() is a matcher on Stmt only (when hasAncestor is a polymorphic matcher). When using it, it does not compile. So I copied the body here. I don't know how bad that is.


http://reviews.llvm.org/D18961





More information about the cfe-commits mailing list