[PATCH] D18823: Implementation of VlA of GNU C++ extension

[Renato Golin via cfe-commits]

rengolin added a subscriber: rengolin.
rengolin added a comment.

En passant comment: I really wish we wouldn't.

The C++ standard had some very careful considerations on VLAs and decided *not* to support. It wasn't for lack of interest, it was a well informed decision.


================
Comment at: llvm/tools/clang/test/SemaCXX/c99-variable-length-array.cpp:1
@@ -1,1 +1,2 @@
-// RUN: %clang_cc1 -fsyntax-only -verify -Wvla-extension %s
+// RUN: %clang_cc1 -fsyntax-only -std=c++98 -DCPP98 -verify -Wvla-extension %s
+// RUN: %clang_cc1 -fsyntax-only -std=gnu++98 -DGNU98 -verify -Wvla-extension %s
----------------
are we not supporting this in c99 anymore?

================
Comment at: llvm/tools/clang/test/SemaCXX/vla.cpp:1
@@ -1,2 +1,2 @@
-// RUN: %clang_cc1 -verify %s
+// RUN: %clang_cc1 -std=c++98 -verify %s
 
----------------
doesn't this remove the test for support for it in c99?


http://reviews.llvm.org/D18823