[PATCH] D18783: [clang-tidy] add new checker for string literal with NUL character.

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 7 09:04:37 PDT 2016


alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.

LG with one nit.


================
Comment at: clang-tidy/misc/StringLiteralWithEmbeddedNulCheck.cpp:70
@@ +69,3 @@
+        diag(SL->getLocStart(), "suspicious embedded NUL character");
+        break;
+      }
----------------
nit: Should this be `return` instead?


http://reviews.llvm.org/D18783





More information about the cfe-commits mailing list