[PATCH] D18369: [OpenCL] Upstreaming khronos OpenCL 1.2/2.0 header files.

Yaxun Liu via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 6 09:09:08 PDT 2016


yaxunl added a comment.

We need to discuss the layout of the header file.

For the builtin functions, I plan to follow the order of the spec and extension spec. If there are difference in 1.2 and 2.0, use condition macro.

For functions with double or half arguments, we have two options:

1. keep all functions with double arguments as one section, keep all functions with half arguments as another section. This is the current layout of opencl-20.h
2. keep functions with the same name together so that they follow the spec order.

Any suggestions? Thanks.


http://reviews.llvm.org/D18369





More information about the cfe-commits mailing list