[PATCH] D18565: Implement an "I'm dtrace, please retain all debug types" option.

David Blaikie via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 6 08:19:25 PDT 2016


Okey dokey - I know one of the things we did (& I don't know when it
happened compared to this change) is emit a hard list of variables onto any
subprogram for an optimized (non -O0) function. So we never lose variables
due to optimizations, or at least that's the intent.

As for D18477, I'm not sure why collectDeadVariables became dead with your
change - I imagine we still want to stuff dead variables into the
subprograms we did create (the ones that weren't /entirely/ optimized away
(ones with remaining inlined instances, etc)) - but maybe we do that
elsewhere?

On Tue, Apr 5, 2016 at 3:14 PM, Adrian Prantl via cfe-commits <
cfe-commits at lists.llvm.org> wrote:

> aprantl abandoned this revision.
> aprantl added a comment.
>
> Meanwhile I made an experiment and compiled XNU with
> http://reviews.llvm.org/D18477 and compared the debug info from before
> and after and found no missing types at all. It is plausible that r107027
> was added to work around the fact that six years ago LLVM was a lot worse
> at preserving debug info for local variables. It is also possible that the
> call graph of the kernel changed in the mean time or a combination of both.
>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D18565
>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160406/eed73289/attachment-0001.html>


More information about the cfe-commits mailing list