[PATCH] D18180: [clang-tidy] Add a check to detect static definitions in anonymous namespace.

Haojian Wu via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 4 07:22:42 PDT 2016


hokein added inline comments.

================
Comment at: clang-tidy/readability/StaticDefinitionInAnonymousNamespaceCheck.cpp:52
@@ +51,3 @@
+                               "anonymous namespace; static is redundant here")
+      << Def->getName();
+  Token Tok;
----------------
alexfh wrote:
> `DiagnosticBuilder` handles hella different stuff. I wonder whether this code works without `->getName()`?
Using `Def` works!


http://reviews.llvm.org/D18180





More information about the cfe-commits mailing list