[PATCH] D18708: Set C99 as default C Standard for PS4 target

Richard Smith via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 1 18:24:20 PDT 2016


rsmith accepted this revision.
rsmith added a reviewer: rsmith.
rsmith added a comment.
This revision is now accepted and ready to land.

In http://reviews.llvm.org/D18708#390150, @dyung wrote:

> From my understanding, there are 2 issues that block us. The first is that we currently do not ship all of the header files for C11. The second is that we do not yet fully have C11 library support yet for our platform.


How do things go wrong if Clang is used in C11 mode against a C99 library? Do you have code that conditionally uses C11 library features if they're available? (And thanks for explaining, by the way; this is useful information for when we next consider changing the default language mode -- we'll likely be changing the default C++ language mode soon.)

Anyway, it seems reasonable for the PS4 toolchain to control its defaults here, and the patch itself LGTM.


http://reviews.llvm.org/D18708





More information about the cfe-commits mailing list