r265038 - Diagnostics: remove dodgy handler for bitcode inlineasm diagnostics.

[Tim Northover via cfe-commits]

> On 31 Mar 2016, at 16:51, Steven Wu <stevenwu at apple.com> wrote:
> 
> The original handler is not there to workaround a crash. It is to avoid generate a crash report (report_fatal_error) when the input bitcode contains invalid assembly. 

Ah, I see now. That test needs tweaking too, since it doesn't actually produce the crash report even after my change (probably because it's a %clang_cc1 test).

How does the patch attached here look? I originally tried reusing the real InlineAsmDiagHandler but that was disastrous (it needs a real AST I think, which obviously doesn't exist when compiling a .bc file).

Cheers.

Tim.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: asm-diagnostics.diff
Type: application/octet-stream
Size: 2589 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160401/04927e20/attachment.obj>