[PATCH] D18649: [clang-tidy] cppcoreguidelines-interfaces-global-init

[Etienne Bergeron via cfe-commits]

etienneb added a subscriber: etienneb.
etienneb added a comment.

some nits.


================
Comment at: clang-tidy/cppcoreguidelines/InterfacesGlobalInitCheck.cpp:21
@@ +20,3 @@
+void InterfacesGlobalInitCheck::registerMatchers(MatchFinder *Finder) {
+  auto IsStaticGlobal =
+      allOf(hasGlobalStorage(),
----------------
nit: const (and below)

================
Comment at: test/clang-tidy/cppcoreguidelines-interfaces-global-init.cpp:42
@@ +41,3 @@
+void f() {
+  // This is fine, it's executed after dynamic initilization occurs.
+  static int G = takesInt(ExternGlobal);
----------------
nit: initilization -> initialization


http://reviews.llvm.org/D18649