[PATCH] D18542: [OPENMP] Parsing and Sema support for 'omp declare target' directive

Dmitry Polukhin via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 1 04:25:37 PDT 2016


DmitryPolukhin updated this revision to Diff 52349.
DmitryPolukhin marked an inline comment as done.
DmitryPolukhin added a comment.

- implemented ad hoc solution for printing
- added documentation for the attrbute
- reabse

In http://reviews.llvm.org/D18542#388241, @aaron.ballman wrote:

> If you don't feel like doing all that design work (which I'm not attempting to sign you up for!), I think the ad hoc solution may be preferable to the proposed approach. Do you intend to add several more pragmas that need this same sort of behavior, or is this a one-off?


I don't expect more pragmas like declare target and grouping mechanism design might be overkill for my case. So I implemented ad hoc solution that is much shorter. PTAL!


http://reviews.llvm.org/D18542

Files:
  include/clang/AST/ASTMutationListener.h
  include/clang/Basic/Attr.td
  include/clang/Basic/AttrDocs.td
  include/clang/Basic/DiagnosticGroups.td
  include/clang/Basic/DiagnosticParseKinds.td
  include/clang/Basic/DiagnosticSemaKinds.td
  include/clang/Basic/OpenMPKinds.def
  include/clang/Sema/Sema.h
  include/clang/Serialization/ASTWriter.h
  lib/AST/ASTContext.cpp
  lib/AST/DeclPrinter.cpp
  lib/Basic/OpenMPKinds.cpp
  lib/Frontend/MultiplexConsumer.cpp
  lib/Parse/ParseOpenMP.cpp
  lib/Sema/SemaDecl.cpp
  lib/Sema/SemaExpr.cpp
  lib/Sema/SemaOpenMP.cpp
  lib/Serialization/ASTCommon.h
  lib/Serialization/ASTReaderDecl.cpp
  lib/Serialization/ASTWriter.cpp
  lib/Serialization/ASTWriterDecl.cpp
  test/OpenMP/declare_target_ast_print.cpp
  test/OpenMP/declare_target_messages.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D18542.52349.patch
Type: text/x-patch
Size: 29624 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160401/29c17a4d/attachment-0001.bin>


More information about the cfe-commits mailing list