[PATCH] D18396: Clang-tidy:modernize-use-override. Fix for __declspec attributes and const=0 without spacse

[Alexander Kornienko via cfe-commits]

alexfh added a comment.

In http://reviews.llvm.org/D18396#388287, @Rob wrote:

> I tried
>
>   check_clang_tidy.py modernize-use-override-ms.cpp modernize-use-override temp -- -- -fms-extensions


It also needs -std=c++11, since you specify options manually and "opt out" of the defaults (which are currently -std=c++11).

> and

> 

>   check_clang_tidy.py modernize-use-override-ms.cpp modernize-use-override temp 

> 

> on OSX and nethier work as expected.

> 

> So instead I have changed the test to use visibility attributes when _MSC_VER is not defined.


... which means that the code is not tested on non-windows platforms, though it could be.

> Also updated the release notes.


Thanks!


================
Comment at: docs/ReleaseNotes.rst:73
@@ +72,3 @@
+
+  The fix-its placement around __declspec attributes on windows and other 
+  attributes is improved.
----------------
nit: Please enclose `__declspec` in double backquotes.


http://reviews.llvm.org/D18396