[PATCH] D18479: [CodeGenCXX] Fix ItaniumCXXABI::getAlignmentOfExnObject to return 8-byte alignment on Darwin
Akira Hatanaka via cfe-commits
cfe-commits at lists.llvm.org
Thu Mar 31 11:39:20 PDT 2016
ahatanak added inline comments.
================
Comment at: cfe/trunk/include/clang/Basic/TargetInfo.h:426
@@ +425,3 @@
+ /// we assume that alignment here. (It's generally 16 bytes, but
+ /// some targets overwrite it.)
+ return getDefaultAlignForAttributeAligned();
----------------
rjmccall wrote:
> This should just be an ordinary comment, not a /// comment.
>
> Please also add this to the documentation comment:
>
> This is only meaningful for targets that allocate C++ exceptions in a system runtime, such as those using the Itanium C++ ABI.
Fixed in r265035.
Repository:
rL LLVM
http://reviews.llvm.org/D18479
More information about the cfe-commits
mailing list