[PATCH] D18369: [OpenCL] Upstreaming khronos OpenCL 1.2/2.0 header files.

[James Price via cfe-commits]

jprice added a subscriber: jprice.
jprice added a comment.

In http://reviews.llvm.org/D18369#387560, @yaxunl wrote:

> In http://reviews.llvm.org/D18369#385799, @Anastasia wrote:
>
> > Is there any chance we could factor out the common bits into separate files to avoid large code repetition? I would imagine it should be quite doable as libs of each standard contain incremental changes.
>
>
> I saw some inconsistencies in the common part of the 1.2 and 2.0 headers. I will try to consolidate them first then try to split.


Rather than having a separate header for each version with another header for the common parts, couldn't we just have a single header that uses #if guards for the version specific functionality? e.g.

  size_t __attribute__((overloadable)) get_global_id(uint dim);
  
  #if __OPENCL_C_VERSION__ >= 200
  size_t __attribute__((overloadable)) get_global_linear_id(void);
  #endif

This also allows an easy path for having OpenCL 1.1 and 1.0 support without having to add more copies of the header.


http://reviews.llvm.org/D18369