[PATCH] D18265: [clang-tidy] New: checker misc-assign-operator-return

[Ádám Balogh via cfe-commits]

Hi,

-----Original Message-----
From: Aaron Ballman [mailto:aaron.ballman at gmail.com] 
Sent: 2016. március 30. szerda 15:57
To: reviews+D18265+public+a31a427ab201a826 at reviews.llvm.org
Cc: Ádám Balogh; Samuel Benzaquen; Alexander Kornienko; Eugene Zelenko; Gábor Horváth; cfe-commits
Subject: Re: [PATCH] D18265: [clang-tidy] New: checker misc-assign-operator-return

I agree with your point; that's why my slight preference is for leaving them split into multiple checks. Either we want this to be the catch-all for operator assignment checks (and plan to use config options to control behavior for additional checks), at which point misc-operator-assign is a reasonable enough name, or we want a clear name for a check that checks two separate-but-related things (one checks the signature, the other checks the return expression value).
I'm not certain we'll get a particularly *clear* name for a check that diagnoses fairly separate issues.

~Aaron

Originally it was a separate checker. However, it was requested to be merged with the existing checker because from the user's perspective it is more logical. In a commercial product this checker is called assign_not_returning_star_this, but it only checks the return value type in the signature and the actual return statements in the body. Neither the parameters nor the qualifiers.

Ádám