[PATCH] D18304: [DarwinDriver] Increase the number of valid digits for ld version string

Duncan P. N. Exon Smith via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 30 15:45:50 PDT 2016


LGTM from the Darwin-side, assuming Reid doesn't have any more comments.

> On 2016-Mar-28, at 13:12, Bruno Cardoso Lopes <bruno.cardoso at gmail.com> wrote:
> 
> bruno updated this revision to Diff 51828.
> bruno added a comment.
> 
> Thanks Reid. The original idea was to have MaxDigits despite the size of the input array (but bounded by its size). But since there are no other users up to this point, your suggestion seems better, updated the patch to reflect it.
> 
> 
> http://reviews.llvm.org/D18304
> 
> Files:
>  include/clang/Driver/Driver.h
>  lib/Driver/Driver.cpp
>  lib/Driver/Tools.cpp
>  test/Driver/darwin-ld.c
> 
> <D18304.51828.patch>



More information about the cfe-commits mailing list